reubano / canviz

Automatically exported from code.google.com/p/canviz
0 stars 0 forks source link

Hello World example shows canviz div doesn't properly unclear itself #62

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create the Hello World example as described under Setup on 
http://code.google.com/p/canviz/wiki/HowToUse.
2. Open the index.html file created in Firefox (I have version 3.6.3). 

What is the expected output? What do you see instead?
I expect both the old and the new way to look alike. Instead the layout
of the new way is weird.

What version of the product are you using? On what operating system?
Firefox 3.6.3 on Ubuntu 10.04.

Original issue reported on code.google.com by lundberg...@gmail.com on 22 Jun 2010 at 8:14

Attachments:

GoogleCodeExporter commented 8 years ago
Not Firefox-specific; probably affects all browsers.

Original comment by ryandesi...@gmail.com on 22 Jun 2010 at 9:14

GoogleCodeExporter commented 8 years ago
this isn't specific to FF. It occurs in all webkit browsers as well. 

The height needs to be set on the container in the draw method as follows:

Index: canviz.js
===================================================================
--- canviz.js   (revision 284)
+++ canviz.js   (working copy)
@@ -639,6 +639,7 @@
            });
            this.container.setStyle({
                width:  width  + 'px'
+               height: height + 'px'
            });
            while (this.elements.firstChild) {
                this.elements.removeChild(this.elements.firstChild);

Original comment by mga...@gmail.com on 22 Jan 2011 at 12:42

GoogleCodeExporter commented 8 years ago
Fixed in r292.

Original comment by ryandesi...@gmail.com on 10 Dec 2011 at 2:18