reubano / csv2ofx

A Python library and command line tool for converting csv to ofx and qif files
MIT License
199 stars 113 forks source link

filter (documentation) #96

Open ondohotola opened 1 year ago

ondohotola commented 1 year ago

In the documentation there are two references to 'filter':

lambda r: r['Amount'] > 10
lambda tr: tr['amount'] > 10

Their use in an amount column with decimals results in

No data to write. '>' not supported between instances of 'str' and 'int'. Try again with '-c' option.

Hence it should perhaps be mentioned in the documentation and changed in the documentation to something like

'filter': lambda tr: float(tr['Amount']) > 10.0

in order to not surprise an unsuspecting user

reubano commented 1 year ago

Good catch. Can you submit a PR with this change?

ondohotola commented 1 year ago

I have absolutely no idea how to do a Pull Request.