reubano / growl

Automatically exported from code.google.com/p/growl
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Idle detection is broken after screen lock #604

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.  Enable screen lock detection
2.  Enable rollup on idle/all notes
2.  Lock the screen
3.  Unlock the screen
4.  Receive a notification

What is the expected output?
Rollup doesn't show because we aren't idle anymore

What do you see instead?
Rollup is shown

Please use labels and text to provide additional information.

Original issue reported on code.google.com by dan...@growl.info on 1 Aug 2013 at 4:56

GoogleCodeExporter commented 8 years ago
Turns out that our idle detection has been wrong since the new version was 
written in march 2012, and while reported, never properly noticed.  2.1 fixed 
the notification center used for Screensaver and lock detection, but didn't 
catch that we never set screenLocked back to NO.

Further, we also had a duplicate listener for NSWorkspaceWillSleepNotification, 
neither of which set asleep to YES, changed one to 
NSWorkspaceDidWakeNotification, and the other to set asleep to YES.  

Will flag as fixed in source as soon as I get it pushed... OSX [Redacted] is 
acting up on me

Original comment by dan...@growl.info on 1 Aug 2013 at 5:12

GoogleCodeExporter commented 8 years ago
FixedInSource as of [9cedaa5dc1d2]

Original comment by dan...@growl.info on 1 Aug 2013 at 5:56