Closed reubeno closed 2 months ago
github-actions[bot]
commented
2 months ago 12 files 69 suites 20s :stopwatch: 411 tests 397 :white_check_mark: 14 :zzz: 0 :x: 413 runs 397 :white_check_mark: 16 :zzz: 0 :x:
Results for commit 92c34c5c.
github-actions[bot]
commented
2 months ago | Benchmark name | Baseline (μs) | Test/PR (μs) | Delta (μs) | Delta % |
|---|---|---|---|---|
expand_one_string |
3.63 μs |
3.63 μs |
-0.00 μs |
⚪ Unchanged |
instantiate_shell |
60.21 μs |
60.06 μs |
-0.15 μs |
⚪ Unchanged |
instantiate_shell_with_init_scripts |
26886.91 μs |
26371.61 μs |
-515.30 μs |
🟢 -1.92% |
parse_bash_completion |
5693.46 μs |
5599.06 μs |
-94.40 μs |
🟢 -1.66% |
parse_sample_script |
8.99 μs |
8.79 μs |
-0.20 μs |
⚪ Unchanged |
run_echo_builtin_command |
92.23 μs |
93.31 μs |
1.08 μs |
⚪ Unchanged |
run_one_builtin_command |
114.47 μs |
113.54 μs |
-0.93 μs |
⚪ Unchanged |
run_one_external_command |
2049.56 μs |
1895.79 μs |
-153.77 μs |
🟢 -7.50% |
run_one_external_command_directly |
967.85 μs |
968.82 μs |
0.97 μs |
⚪ Unchanged |
| Package | Base Coverage | New Coverage | Difference |
|---|---|---|---|
| brush-core/src/arithmetic.rs | 🟢 97.44% | 🟢 97.42% | 🔴 -0.02% |
| brush-core/src/error.rs | 🔴 25% | 🔴 0% | 🔴 -25% |
| brush-core/src/shell.rs | 🟢 78.06% | 🟢 77.9% | 🔴 -0.16% |
| brush-parser/src/error.rs | 🟢 76.92% | 🟢 100% | 🟢 23.08% |
| brush-parser/src/tokenizer.rs | 🟢 96.01% | 🟢 96.13% | 🟢 0.12% |
| Overall Coverage | 🟢 76.24% | 🟢 76.26% | 🟢 0.02% |
Minimum allowed coverage is 70%, this run produced 76.26%
These tests are succeeding locally but seem to sometimes(?) fail in GitHub action runs (example: #147). To unblock PRs, I'm going to disable these recent additions until we can sort out what's going on.