reubeno / brush

bash/POSIX-compatible shell implemented in Rust
MIT License
26 stars 4 forks source link

fix: address multiple issues with foreground controls for pipeline commands #180

Closed reubeno closed 1 month ago

github-actions[bot] commented 1 month ago

Test Results

  2 files    8 suites   1m 5s :stopwatch: 424 tests 424 :white_check_mark: 0 :zzz: 0 :x: 848 runs  848 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 23282a30.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 month ago

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.36 μs 3.36 μs -0.00 μs ⚪ Unchanged
instantiate_shell 60.43 μs 60.26 μs -0.17 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 25208.21 μs 25506.81 μs 298.60 μs ⚪ Unchanged
parse_bash_completion 5725.14 μs 5719.23 μs -5.91 μs ⚪ Unchanged
parse_sample_script 8.96 μs 9.00 μs 0.04 μs ⚪ Unchanged
run_echo_builtin_command 92.42 μs 92.14 μs -0.28 μs ⚪ Unchanged
run_one_builtin_command 112.37 μs 113.41 μs 1.04 μs ⚪ Unchanged
run_one_external_command 1826.22 μs 1882.34 μs 56.12 μs 🟠 +3.07%
run_one_external_command_directly 969.75 μs 958.35 μs -11.40 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/commands.rs 🟢 91% 🟢 90.2% 🔴 -0.8%
brush-core/src/interp.rs 🟢 89.66% 🟢 89.76% 🟢 0.1%
brush-core/src/sys/unix/signal.rs 🟠 63.64% 🟠 68.48% 🟢 4.84%
brush-core/src/sys/unix/terminal.rs 🔴 36.07% 🔴 37.74% 🟢 1.67%
Overall Coverage 🟢 76.14% 🟢 76.2% 🟢 0.06%

Minimum allowed coverage is 70%, this run produced 76.2%