reubeno commented 1 month ago

Newlines can appear right after the [[ or right before the ]], as well as around && and || operators.

github-actions[bot] commented 1 month ago

Test Results

2 files 8 suites 50s :stopwatch: 423 tests 423 :white_check_mark: 0 :zzz: 0 :x: 846 runs 846 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 970f4a71.

github-actions[bot] commented 1 month ago

Performance Benchmark Report

Benchmark name	Baseline (μs)	Test/PR (μs)	Delta (μs)	Delta %
`expand_one_string`	`3.35 μs`	`3.35 μs`	`-0.00 μs`	`⚪ Unchanged`
`instantiate_shell`	`61.03 μs`	`60.79 μs`	`-0.24 μs`	`⚪ Unchanged`
`instantiate_shell_with_init_scripts`	`25733.13 μs`	`25996.26 μs`	`263.13 μs`	`⚪ Unchanged`
`parse_bash_completion`	`2713.49 μs`	`2722.38 μs`	`8.90 μs`	`⚪ Unchanged`
`parse_sample_script`	`3.96 μs`	`4.01 μs`	`0.05 μs`	`🟠 +1.36%`
`run_echo_builtin_command`	`89.23 μs`	`88.44 μs`	`-0.79 μs`	`⚪ Unchanged`
`run_one_builtin_command`	`109.60 μs`	`109.86 μs`	`0.26 μs`	`⚪ Unchanged`
`run_one_external_command`	`2003.69 μs`	`1902.14 μs`	`-101.56 μs`	`🟢 -5.07%`
`run_one_external_command_directly`	`960.04 μs`	`958.97 μs`	`-1.07 μs`	`⚪ Unchanged`

Package	Base Coverage	New Coverage	Difference
brush-core/src/shell.rs	🟢 76.58%	🟢 76.43%	🔴 -0.15%
Overall Coverage	🟢 72.45%	🟢 72.44%	🔴 -0.01%

Minimum allowed coverage is 70%, this run produced 72.44%