reubeno / brush

bash/POSIX-compatible shell implemented in Rust
MIT License
20 stars 4 forks source link

feat: implement command hashing #206

Closed reubeno closed 2 weeks ago

reubeno commented 2 weeks ago
github-actions[bot] commented 2 weeks ago

Test Results

  2 files    9 suites   59s :stopwatch: 468 tests 468 :white_check_mark: 0 :zzz: 0 :x: 927 runs  927 :white_check_mark: 0 :zzz: 0 :x:

Results for commit 2ed573ac.

github-actions[bot] commented 2 weeks ago

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.34 μs 3.41 μs 0.06 μs 🟠 +1.94%
instantiate_shell 59.48 μs 60.80 μs 1.32 μs 🟠 +2.22%
instantiate_shell_with_init_scripts 28925.93 μs 28267.34 μs -658.59 μs 🟢 -2.28%
parse_bash_completion 2711.50 μs 2733.14 μs 21.64 μs ⚪ Unchanged
parse_sample_script 4.15 μs 4.09 μs -0.06 μs ⚪ Unchanged
run_echo_builtin_command 90.70 μs 91.62 μs 0.93 μs ⚪ Unchanged
run_one_builtin_command 107.99 μs 114.55 μs 6.55 μs 🟠 +6.07%
run_one_external_command 1939.55 μs 1979.37 μs 39.82 μs 🟠 +2.05%
run_one_external_command_directly 1005.99 μs 1009.78 μs 3.80 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/command.rs 🟢 91.95% 🟢 91.86% 🔴 -0.09%
brush-core/src/builtins/hash.rs 🔴 0% 🟢 89.66% 🟢 89.66%
brush-core/src/builtins/printf.rs 🟢 91.84% 🟢 92% 🟢 0.16%
brush-core/src/builtins/type_.rs 🟢 79.76% 🟢 80.95% 🟢 1.19%
brush-core/src/commands.rs 🟢 85.58% 🟢 86.43% 🟢 0.85%
brush-core/src/escape.rs 🟢 86.91% 🟢 87.18% 🟢 0.27%
brush-core/src/pathcache.rs 🔴 0% 🟢 100% 🟢 100%
brush-core/src/shell.rs 🟢 81.95% 🟢 82.45% 🟢 0.5%
brush-core/src/sys/unix/signal.rs 🟠 72.13% 🟢 75.41% 🟢 3.28%
Overall Coverage 🟢 75.44% 🟢 75.63% 🟢 0.19%

Minimum allowed coverage is 70%, this run produced 75.63%