search

reugn / go-quartz

Minimalist and zero-dependency scheduling library for Go
https://pkg.go.dev/github.com/reugn/go-quartz/quartz
MIT License
1.8k stars 85 forks source link

scheduler: wait for all threads #43

Closed tychoish closed 1 year ago

tychoish commented 1 year ago

I was working on an integration with this and I realized that as implemented Wait() doesn't wait for very much to be done, this improves that situation.

codecov-commenter commented 1 year ago

Codecov Report

Merging #43 (ec5577b) into master (a3e457b) will decrease coverage by 0.29%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   84.81%   84.51%   -0.30%     
==========================================
  Files           7        7              
  Lines         665      678      +13     
==========================================
+ Hits          564      573       +9     
- Misses         70       77       +7     
+ Partials       31       28       -3
Impacted Files Coverage Δ
quartz/scheduler.go 92.65% <88.88%> (+1.19%) :arrow_up:
quartz/job.go 81.25% <0.00%> (-7.82%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.