search

reuixiy / hugo-theme-meme

😝 You can’t spell awesome without MemE!
https://io-oi.me/hugo-theme-meme
MIT License
1.01k stars 279 forks source link

Add search functionality? #163

Closed palant closed 4 years ago

palant commented 4 years ago

Would it make sense to contribute the search functionality from palant.info? Hugo website recommends hugo-lunr for lunr.js integration which is an unnecessarily complicated way to do it and will fail in some scenarios. This functionality can be easily integrated into a theme, with lunr.js script as the only external dependency. The search itself will work on the client side then, without any server-side support (search index generated as a JSON file by Hugo itself).

he-sb commented 4 years ago

It would be awesome!🎉

reuixiy commented 4 years ago

Guess we can do it then.

dawnow commented 4 years ago

@reuixiy Is this guy's wish coming true? https://github.com/reuixiy/hugo-theme-meme/issues/84

reuixiy commented 4 years ago

@dawnow Hmmm, not sure, as that issue is lack of description... Anyway, maybe we can close it when we close this. 🤔

palant commented 4 years ago

Ok, I'm generalizing the code, will create a pull request shortly.

palant commented 4 years ago

Pull request is #165.