search

reujab / silver

A cross-shell customizable powerline-like prompt with icons
MIT License
453 stars 30 forks source link

Zack/handle login shells #68

Open zackw opened 3 years ago

zackw commented 3 years ago

Fixes #67. See commit comments for details of each change.

Note that I disabled the rustfmt part of the pre-commit hook, because I got a flood of errors about options only available with nightly rust, and then it wanted to reformat huge blocks of code that I didn't even touch. I apologize if this means these patches introduce bad formatting. Fixed in the rebased branch.

thecaralice commented 3 years ago

I like this PR, but it has a lot of unrelated changes that should be put in a separate PR.

zackw commented 3 years ago

@j0hnmeow I'm happy to split up the PR, but how fine-grained do you want it? One PR for each of the three commits, or do I need to break up c2ff279, and if so, what do you think would be logical boundaries?

thecaralice commented 3 years ago

For this PR it's enough to have a shell option in config, SILVER_SHELL variable and code for trimming the -. Fixing clippy warnings and documentation should go in their own PRs

zackw commented 3 years ago

OK. It might be a couple days before I get to this, I need to work on unrelated stuff today.