reunu / unustasis

An open-source app for the Unu Scooter Pro
Apache License 2.0
27 stars 7 forks source link

"Auto-open box" sometimes does not unlock, only open the seat #27

Open TheFreal opened 3 months ago

TheFreal commented 3 months ago

Reported: https://discord.com/channels/1214696072962908190/1232812789777563659/1246237757781704776 Replicated: Corroborated by multiple users, seems plausible

Ich habe die Einstellung aktiviert, dass beim Entriegeln der Sitz automatisch geöffnet wird. Das funktioniert problemlos, wenn der Hauptakku im Roller ist. Ist der Hauptakku nicht im Roller (bei mir idR jeden Morgen), öffnet sich durch halten des Entriegeln Buttons nur der Sitz. Erst wenn ich den Button ein zweites Mal halte, entriegelt der Scooter (und der Sitz auch nochmal). Hab das lange beobachtet und kann das jedes Mal reproduzieren.

Probably caused by low bluetooth speed, multiple commands being sent out but only one making it to the scooter.

DSIW commented 3 months ago

~Isn't it duplicated? see https://github.com/reunu/unustasis/issues/28~

TheFreal commented 3 months ago

@DSIW You think it's caused by the same thing?

DSIW commented 3 months ago

I reread the issues again and indeed, both issues are different.

Currently it's implemented by:

  1. unlock
  2. blink if activated
  3. open seat if activated

I would've thought that the scooter would process them as FIFO. Therefore I'm not sure what the issue is. We could think about adding some timeouts in millis between those commands. But I wouldn't be sure if that would really solve it...

TheFreal commented 3 months ago

Doesn't hurt to try I guess...