bugfix: folder based deck name not working properly

reuseman / flashcards-obsidian

🎴 An Anki plugin for Obsidian.md

MIT License

872 stars 86 forks source link

bugfix: folder based deck name not working properly #101

Closed Hxppdv closed 1 year ago

Hxppdv commented 2 years ago

The frontmatter is used to specify the deck of the card, but sometimes you don't specify the deck of the card and there is something else in the frontmatter, which causes the deck name to become the default name instead of the folder-based name.

Nizar-Rahme commented 1 year ago

Thanks @reuseman for this good plugin.

I ran into the same issue as well. Are there any blockers for getting this PR merged?

reuseman commented 1 year ago

Just done @Nizar-Rahme.

Thanks again to @Hxppdv

Nizar-Rahme commented 1 year ago

Thanks @reuseman!

Are you planning for a new release? 😊

putzwasser commented 1 year ago

Shouldn't lines 61 and 62 be:

    if (obsidian.parseFrontMatterEntry(frontmatter, "cards-deck")) {
      deckName = obsidian.parseFrontMatterEntry(frontmatter, "cards-deck");

instead of just

    if (parseFrontMatterEntry(frontmatter, "cards-deck")) {
      deckName = parseFrontMatterEntry(frontmatter, "cards-deck");