search

reuseman / flashcards-obsidian

๐ŸŽด An Anki plugin for Obsidian.md
MIT License
897 stars 87 forks source link

Added hide ID setting #84

Closed milkyskies closed 2 years ago

milkyskies commented 2 years ago

When enabled, wraps all IDs in <!-- and -->, making them an HTML comment so that they will be hidden, increasing visibility.

Please forgive me if this is bad GitHub convention; I have never participated in contributing to a project before.

Fixes #83.

reuseman commented 2 years ago

Don't worry, pull requests are always more than welcomed, and I really appreciate it. But I am not getting the advantage of the HTML comment over the ID. The ID out of the box is smaller in edit mode and in preview both of them are invisible. I cannot see the benefit, but it seems that code just gets more complicated and hence harder to maintain it.

Edit mode image Preview image

milkyskies commented 2 years ago

Hi, thanks for taking a look. For some reason, I failed to check the preview mode with the original code ๐Ÿ˜‚ Not the smartest move on my part.

Any other issues that I could help with?

2022ๅนด2ๆœˆ14ๆ—ฅ(ๆœˆ) 7:12 Alex Colucci @.***>:

Don't worry, pull requests are always more than welcomed, and I really appreciate it. But I am not getting the advantage of the HTML comment over the ID. The ID out of the box is smaller in edit mode and in preview both of them are invisible. I cannot see the benefit, but it seems that code just gets more complicated and hence harder to maintain it.

Edit mode [image: image] https://user-images.githubusercontent.com/17575915/153777372-c200d2c9-a838-49d0-87ce-f88c169ea5ca.png Preview [image: image] https://user-images.githubusercontent.com/17575915/153777375-4595077e-8c45-4137-a8fc-ebd5c9c2f0af.png

โ€” Reply to this email directly, view it on GitHub https://github.com/reuseman/flashcards-obsidian/pull/84#issuecomment-1038452539, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQK63X6Y4PRGCY2ZS4LEG3U3AUFHANCNFSM5OJGA36A . You are receiving this because you authored the thread.Message ID: @.***>

reuseman commented 2 years ago

There is #82 that should be doable, given the fact that it seems that you're able to figure out where to put stuff in the regex and in the settings. I would solve the issue by having two options that allows to disable cloze with brackets and cloze with highlights.