search

reustle / covid19japan

https://covid19japan.com
MIT License
271 stars 101 forks source link

added static map on load and dynamic map will replace it on click #495

Closed AndriiAndrey closed 3 years ago

AndriiAndrey commented 3 years ago

added static map on load and dynamic map will replace it on click, change initDataTranslate and loadDataOnPage methods to asynchronous , to make sure it will load first before run other code which require initialised translation and server data, some common code moved to helpers and drawLegend moved to separate file in OutbreakMap folder

// Please include a screenshot of any visual changes you've made Static map on load looks basically the same https://monosnap.com/file/INT8h5shFoDGaQyeIogjhgNooTYJ4T

a-ogilvie commented 3 years ago

The map in the screenshot looks a little distorted 👀

image

Also, the deploy preview is broken: https://deploy-preview-495--covid19japan.netlify.app/

reustle commented 2 years ago

Hey @AndriiAndrey - if you have a chance it would be great if you could check out https://github.com/reustle/covid19japan/issues/505 - Thanks again for the contribution!

@a-ogilvie I'll submit this as a separate issue if it's still happening