search

reuters-graphics / bluprint_graphics-kit

SvelteKit rig for graphics and newsapps
https://reuters-graphics.github.io/docs_graphics-kit/
21 stars 3 forks source link

Propose adding a layout page and use the Theme wrapper at that level. #105

Closed pkd2512 closed 1 year ago

pkd2512 commented 1 year ago

Maybe even move the analytics and headers to that level, so page.svelte looks cleaner. Can have some smart checks for embeds to not include the header maybe.

hobbes7878 commented 1 year ago

I don't think we can do this because the outer +layout will override embeds, which should technically always be on white background. (I know we tend not to reverse it for a full page embed, but still want the split between pages and embeds baked in, not something users have to override to do correctly.)