W3C markup validation - Githubissues

reuters-graphics / bluprint_graphics-kit

SvelteKit rig for graphics and newsapps

https://reuters-graphics.github.io/docs_graphics-kit/

21 stars 3 forks source link

W3C markup validation #59

Closed pkd2512 closed 2 years ago

pkd2512 commented 2 years ago

It's a good practice to have websites that pass W3C validation. Helps with cross-platform compliance, accessibility and SEO

Nice to have -

Check and validate existing markup
Add a validator in the workflow to show warnings and errors
Make grammatically correct coding easier

Sample from one of our web pages built with sveltekit

hobbes7878 commented 2 years ago

I hear this, but we're limited to how SvelteKit creates the markup from our components. Their conventions trump ours because we're using their tool. That said if there are any major issues, we want to identify them specifically and make tickets on SvelteKit's repo for them to address.

pkd2512 commented 2 years ago

I see. So, as you can see in the preview, some of those errors appear in the meta tags, terminated by a fatal error. While I am unsure how it affects the page, however, some of them might just be about fixing some meta props etc. Will do some more audit and get back