search

reuters-graphics / bluprint_graphics-kit

SvelteKit rig for graphics and newsapps
https://reuters-graphics.github.io/docs_graphics-kit/
21 stars 3 forks source link

share card question #61

Closed travishartman closed 2 years ago

travishartman commented 2 years ago

i'm seeing this share card path in the archieML doc:

ShareImgPath: images/reuters-graphics.jpg

It's been a hot minute since i've pubbed a thing and seems like we used to name sharecards share-card.jpg, but curious now if this default is a templated name (i.e. we should save sharecards with the name reuters-graphics.jpg and overwrite) or do we simply change the path in the doc? and if the latter, why not change the doc to read

ShareImgPath: images/share-card.jpg

?

hobbes7878 commented 2 years ago

Yeah, you can name your share cards whatever you like now. The rig will handle appropriately.

Just set the path in your google doc (which then gets passed to our SEO component) and Bob's your nuncle.

hobbes7878 commented 2 years ago

Oh, and it's set to that reuters-graphics.jpg cause that's a default image we include in kit when you start up, but always presumed you'd add your own share card and rewrite that path. Also valid to just replace the image, too, and leave the path. The world is yours.

travishartman commented 2 years ago

well, it's obviously a small thing, but in the best of all possible worlds, it seems like the default share card would be called what it is, i.e. sharecard.jpg or share-card or what have you. that's my 2 pence and i'll leave it at that.

hobbes7878 commented 2 years ago

I get that, and you can totally use it like that: so reuters-graphics.jpg is, for all intents and purposes, the share card, and you can just replace it each project.

The thing that's moderately different about the new kit is it does multiple pages and embeds now, so for some projects there are actually several share cards, one for each page. We even use them on embeds to make preview images for clients in Connect. So I guess we broke the naming convention for one share card because that functionality is new..