search

reuters-graphics / graphics-kit-publisher

Publishing CLI for Reuters graphics pages and embeds
https://reuters-graphics.github.io/graphics-kit-publisher/
MIT License
4 stars 0 forks source link

Homepage for clients errors #33

Closed hobbes7878 closed 2 years ago

hobbes7878 commented 2 years ago

I think this test is gonna create an error for clients who want to customize graphics: https://github.com/reuters-graphics/graphics-kit-publisher/blob/master/test/pack.js#L77-L86

Should probably remove this check, or instead just look for a valid URL.

hobbes7878 commented 2 years ago

Second thought: No, should be OK b/c clients will use build script directly: https://reuters-graphics.github.io/docs_graphics-kit/for_clients/using-the-kit/#building-for-self-hosting