search

rev087 / ng-inspector

The AngularJS inspector pane for your browser
ng-inspector.org
MIT License
783 stars 93 forks source link

Made the default text color black #131

Closed davidfurlong closed 9 years ago

davidfurlong commented 9 years ago

When the page has body {color:white} many of the titles are illegible (as they are inherit the color white) See image for example screen shot 2015-08-19 at 14 41 01

rev087 commented 9 years ago

@DrewML seems like the Sauce Labs tunnel failed here:

Angular Version: 1.1.4 - Build: 4
Invalid tunnel_identifier 4.1

I'm not sure what's going wrong here, maybe you can help?

DrewML commented 9 years ago

@rev087 I have a suspicion, but I'll need you to test. Do a git checkout on @davidfurlong's branch on your local machine. Then, push it to this repositories remote (rather than David's forks remote), and check if the tests pass in CI once you push that branch.

Checkout PR branch locally: https://help.github.com/articles/checking-out-pull-requests-locally/ Possible reason for failure: http://docs.travis-ci.com/user/pull-requests/#Security-Restrictions-when-testing-Pull-Requests

Let me know if the tests pass with this branch on your remote. If so, I can update our setup to not run E2E tests automatically on a PR.

DrewML commented 9 years ago

@rev087 Yep, the "Security Restrictions" link above definitely described the problem we're hitting. Just pushed David's branch to my own fork/CI setup, and it built/passed no problem.

https://travis-ci.org/DrewML/ng-inspector/builds/76395491

I had read about this when setting up CI, but apparently just never remembered to test sigh.

Here is the tl;dr of what's going on: Typically, people store their sensitive credentials (such as a saucelabs access key) in secure environment variables within Travis. Travis is trying to protect us by disallowing someone to submit a PR that just adds code to travis.yml to spit out the environment variables (this is done by not exposing environment variables to branches outside of the main repository).

Having said that, I don't really think it's crucial for us to hide/protect those credentials (which is why I didn't encrypt them when configuring our CI setup). Since the SauceLabs account is free and not connected to any payment methods, there isn't really a huge risk. Worst case scenario is that someone could run tests against our free SauceLabs account. I think the trade-off (letting contributors see if their PR passes tests) is well worth it.,

I'm working on a fix right now