revarbat / BOSL

The Belfry OpenScad Library - A library of tools, shapes, and helpers to make OpenScad easier to use.
https://github.com/revarbat/BOSL/wiki
BSD 2-Clause "Simplified" License
571 stars 62 forks source link

gears have problems when rendering #52

Closed iplayfast closed 5 years ago

iplayfast commented 5 years ago

Adding a circle to gears union cleans up rendering problems by simplifying the structure. (at line 241 just add "circle(r);")

git diff diff --git a/involute_gears.scad b/involute_gears.scad index ff32f04..0ba8d14 100644 --- a/involute_gears.scad +++ b/involute_gears.scad @@ -238,6 +238,7 @@ module gear2d( ]); } }

revarbat commented 5 years ago

This appears to be a PR to the attachments branch, which was abandoned, as attachments was deferred to https://github.com/revarbat/BOSL2/

revarbat commented 5 years ago

The proposed addition of circle() to the union is also incorrect for partial gears where teeth_to_hide is not 0.