revarbat / BOSL

The Belfry OpenScad Library - A library of tools, shapes, and helpers to make OpenScad easier to use.
https://github.com/revarbat/BOSL/wiki
BSD 2-Clause "Simplified" License
571 stars 62 forks source link

[BUG] - involute_gears are unusable #73

Closed ftlpilot closed 4 years ago

ftlpilot commented 4 years ago

involute_gears. are unusable - the 2D shape is WRONG and doesn't extrude to 3D - this was supposedly fixed, but it' still there today - here's a screenshot of the example code.

bosl-bugs

This would be a really nice library - IF IT ACTUALLY WORKED !!!

mjparme commented 4 years ago

I have used involute-gears just fine before. What do you mean it is unusable?

ftlpilot commented 4 years ago

The inside is hollow and they can’t be rendered – look CAREFULLY at the pic I included, there is just an outer skin – THE CENTER IS MISSING, also this problem has been reported before.

Don’t rely on using them before – CHECK THEM NOW – THEY DON’T FUCKING WORK !!!!!!!!!!!!!

From: Michael Parmeley [mailto:notifications@github.com] Sent: Tuesday, 13 October 2020 11:38 To: revarbat/BOSL BOSL@noreply.github.com Cc: ftlpilot github@rce.com.au; Author author@noreply.github.com Subject: Re: [revarbat/BOSL] [BUG] - involute_gears are unusable (#73)

I have used involute-gears just fine before. What do you mean it is unusable?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/revarbat/BOSL/issues/73#issuecomment-707415752 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53UK5BJXRD6B6CINJPYUDSKOOOZANCNFSM4R5GUX6Q . https://github.com/notifications/beacon/AB53UK5JSJ5YQZ2BJUWLRE3SKOOOZA5CNFSM4R5GUX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFIVE5SA.gif

-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

revarbat commented 4 years ago

Took a bit to figure this one out. gear2d() was using tooth profiles that had very slightly overlapping lines between consecutive teeth. When that path was converted to a polygon via polygon(), it looked fine, but internally had a bad geometry, so that linear_extrude() failed to extrude it correctly.

Fixed in 56756cc137281b4319dea5083262f22c7aa0b804

ftlpilot commented 4 years ago

Thankx – much appreciated, I’ll try and work in a mention in my next DIYODE article about gears, probably Dec or Jan issue.

From: Revar Desmera [mailto:notifications@github.com] Sent: Thursday, 15 October 2020 11:02 To: revarbat/BOSL BOSL@noreply.github.com Cc: ftlpilot github@rce.com.au; Author author@noreply.github.com Subject: Re: [revarbat/BOSL] [BUG] - involute_gears are unusable (#73)

Took a bit to figure this one out. gear2d() was using tooth profiles that had very slightly overlapping lines between consecutive teeth. When that path was converted to a polygon via polygon(), it looked fine, but internally had a bad geometry, so that linear_extrude() failed to extrude it correctly.

Fixed in https://github.com/revarbat/BOSL/commit/56756cc137281b4319dea5083262f22c7aa0b804 56756cc

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/revarbat/BOSL/issues/73#issuecomment-708722632 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53UKZ3NHWBA7KZGRFUKRTSKY3XPANCNFSM4R5GUX6Q . https://github.com/notifications/beacon/AB53UKZCMC6YIQT4VQAYPY3SKY3XPA5CNFSM4R5GUX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFI7D7SA.gif

=========================

Thankx

Geoff Cohen

https://www.thingiverse.com/geoff_cohen/designs https://www.thingiverse.com/geoff_cohen/designs

https://diyodemag.com/projects/fixing_firmware_updating_firmware_on_the_arduino_bootloader_part_2 https://diyodemag.com/projects/fixing_firmware_updating_firmware_on_the_arduino_bootloader_part_2

https://diyodemag.com/education/exploring_3d_3d_printed_gears_part_1 https://diyodemag.com/education/exploring_3d_3d_printed_gears_part_1

-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

ftlpilot commented 4 years ago

Thanks again – gears work perfectly now – I’ll give your Library a mention in my next DIYODE article about Gears, in the next month or two.

FYI, the 1st Gears article is at https://diyodemag.com/education/exploring_3d_3d_printed_gears_part_1 https://diyodemag.com/education/exploring_3d_3d_printed_gears_part_1

From: Revar Desmera [mailto:notifications@github.com] Sent: Thursday, 15 October 2020 11:02 To: revarbat/BOSL BOSL@noreply.github.com Cc: ftlpilot github@rce.com.au; Author author@noreply.github.com Subject: Re: [revarbat/BOSL] [BUG] - involute_gears are unusable (#73)

Closed #73 https://github.com/revarbat/BOSL/issues/73 .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/revarbat/BOSL/issues/73#event-3878974482 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53UKZ3NHWBA7KZGRFUKRTSKY3XPANCNFSM4R5GUX6Q . https://github.com/notifications/beacon/AB53UKZ3ABPZE2ZTXT5FXB3SKY3XPA5CNFSM4R5GUX62YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGO442HIEQ.gif

-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

revarbat commented 4 years ago

Honestly, for gears code I'd use the involute_gears.scad file in the BOSL2 library, not BOSL1. In BOSL2 I did a complete rewrite that renders faster and more accurately. Also it has proper support for spiral bevel gears and worm gears.

ftlpilot commented 4 years ago

Thankx – until you mentioned it I didn’t know there WAS a V2 – perhaps mentioning BOSL2 on https://www.openscad.org/libraries.html would be a good idea, at least when it’s out of alpha/beta testing

From: Revar Desmera [mailto:notifications@github.com] Sent: Sunday, 25 October 2020 14:37 To: revarbat/BOSL BOSL@noreply.github.com Cc: ftlpilot github@rce.com.au; Author author@noreply.github.com Subject: Re: [revarbat/BOSL] [BUG] - involute_gears are unusable (#73)

Honestly, for gears code I'd use the involute_gears.scad file in the BOSL2 library, not BOSL1. In BOSL2 I did a complete rewrite that renders faster and more accurately. Also it has proper support for spiral bevel gears and worm gears.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/revarbat/BOSL/issues/73#issuecomment-716088887 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53UK4M2MNQI55GYFJ36PDSMOMMLANCNFSM4R5GUX6Q . https://github.com/notifications/beacon/AB53UK4CXD75FET5CNFM4YLSMOMMLA5CNFSM4R5GUX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFKXKMNY.gif

-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

ftlpilot commented 4 years ago

As you suggested, I tried the the involute_gears.scad file in the BOSL2 library – it’s pretty much unusable, firstly there was no include/use statement for attachments, when I inserted one in my code – this was the result

WARNING: Ignoring unknown function 'is_vector', in file ../../../../Users/Geoff/Documents/OpenSCAD/libraries/BOSL2/attachments.scad, line 220.

ERROR: Assertion 'is_vector(cp)' failed in file ../../../../Users/Geoff/Documents/OpenSCAD/libraries/BOSL2/attachments.scad, line 220

TRACE: called by 'attach_geom', in file ../../../../Users/Geoff/Documents/OpenSCAD/libraries/BOSL2/attachments.scad, line 910.

TRACE: called by 'attachable', in file ../../../../Users/Geoff/Documents/OpenSCAD/libraries/BOSL2/Involute_gears.scad, line 700.

TRACE: called by 'gear', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1590.

TRACE: called by 'translate', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1589.

TRACE: called by 'union', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1569.

TRACE: called by 'difference', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1568.

TRACE: called by 'Geoffs_double_helix', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1538.

TRACE: called by 'rotate', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1537.

TRACE: called by 'translate', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1536.

TRACE: called by 'color', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1535.

TRACE: called by 'union', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1521.

TRACE: called by 'difference', in file Geoffs-Dual-Geared-Extruder-All-3D-printed-Mk21v.scad, line 1520.

From: Revar Desmera [mailto:notifications@github.com] Sent: Sunday, 25 October 2020 14:37 To: revarbat/BOSL BOSL@noreply.github.com Cc: ftlpilot github@rce.com.au; Author author@noreply.github.com Subject: Re: [revarbat/BOSL] [BUG] - involute_gears are unusable (#73)

Honestly, for gears code I'd use the involute_gears.scad file in the BOSL2 library, not BOSL1. In BOSL2 I did a complete rewrite that renders faster and more accurately. Also it has proper support for spiral bevel gears and worm gears.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/revarbat/BOSL/issues/73#issuecomment-716088887 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53UK4M2MNQI55GYFJ36PDSMOMMLANCNFSM4R5GUX6Q . https://github.com/notifications/beacon/AB53UK4CXD75FET5CNFM4YLSMOMMLA5CNFSM4R5GUX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFKXKMNY.gif

-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

revarbat commented 4 years ago

In BOSL2, you want to do:

include <BOSL2/std.scad>
include <BOSL2/involute_gears.scad>
ftlpilot commented 4 years ago

Thankx again – missed the info about std.scad at the beginning of the file

From: Revar Desmera [mailto:notifications@github.com] Sent: Thursday, 19 November 2020 08:06 To: revarbat/BOSL BOSL@noreply.github.com Cc: ftlpilot github@rce.com.au; Author author@noreply.github.com Subject: Re: [revarbat/BOSL] [BUG] - involute_gears are unusable (#73)

In BOSl2, you want to do:

include <BOSL2/std.scad> include <BOSL2/involute_gears.scad>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/revarbat/BOSL/issues/73#issuecomment-729953155 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AB53UK2WXTG2WFA6VPSS4CLSQQZMJANCNFSM4R5GUX6Q . https://github.com/notifications/beacon/AB53UK6AVXW6572Z332BX23SQQZMJA5CNFSM4R5GUX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFOBDHAY.gif

-- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus