search

revarbat / BOSL

The Belfry OpenScad Library - A library of tools, shapes, and helpers to make OpenScad easier to use.
https://github.com/revarbat/BOSL/wiki
BSD 2-Clause "Simplified" License
572 stars 63 forks source link

[BUG] Documentation - Threading.scad - Inconsistent description for default value of slop #81

Closed fe60 closed 3 years ago

fe60 commented 3 years ago

Describe the bug The documentation describes the default value of slop in two different ways.

  1. Default: PRINTER_SLOP
  2. default=0.2

Version 2 is used for the following modules: https://github.com/revarbat/BOSL/wiki/threading.scad#threaded_nut https://github.com/revarbat/BOSL/wiki/threading.scad#buttress_threaded_rod https://github.com/revarbat/BOSL/wiki/threading.scad#buttress_threaded_nut https://github.com/revarbat/BOSL/wiki/threading.scad#acme_threaded_nut https://github.com/revarbat/BOSL/wiki/threading.scad#square_threaded_nut

Expected behavior The default value should be mentioned in a consistent way. I prefer version 1 referring to the global variable.

fe60 commented 3 years ago

Fixed in fork of wiki https://github.com/fe60/bosl-wiki/commit/c1518e140cb780945f9f120c8c3d547ef4ea1db0