revaturelabs / caliber-2-meta

Meta Repository for Caliber 2

5 stars 1 forks source link

Remove alert() call after addTrainer #104

Closed LTCHIPS closed 5 years ago

LTCHIPS commented 5 years ago

Remove alert() call after addTrainer call

Description

The addTrainer method found in add-trainer.component.ts currently uses an alert() call to prompt the user that a trainer was successfully added. This is not a good idea since alert() blocks threads. Prompt the user with something other than an alert().

LTCHIPS commented 5 years ago

Pull request that addresses this issue: https://github.com/revaturelabs/caliber-2-angular/pull/117

LTCHIPS commented 5 years ago

The pull request in my previous commit has been merged into dev, so I am closing this issue.