revaturelabs / caliber-2-meta

Meta Repository for Caliber 2
5 stars 1 forks source link

Add new assessment categories #71

Open Quinn-Donnelly opened 5 years ago

Quinn-Donnelly commented 5 years ago

As a VP, I can add new assessment categories

Chickwen1 commented 5 years ago

Sara (back end) Jacob (front end)

Chickwen1 commented 5 years ago

Story points: 57 total hours

Chickwen1 commented 5 years ago

@Quinn-Donnelly whenever I push my code, the tests are not showing up within the SonarCloud

Quinn-Donnelly commented 5 years ago

@Chickwen1 I can show in next standup for now run the lifecycle method that is listed in the pom to generate the report. We are transitioning our SonarCloud env so it might not auto update at the moment. However, if you would like to see your metrics you should be able to generate a jaccoco report locally.

VossJacob commented 5 years ago

@Quinn-Donnelly Wondering how you want us to handle getting the category owner for adding a new assessment category. Since we don't have a login feature available. There isn't a way to pull user info to set the category owner automatically. Could add an input text field in the add assessment modal, but not sure if that's what you had in mind.

Chickwen1 commented 5 years ago

@Quinn-Donnelly I have around 73% code coverage when I check the coverage within STS. On the SonarCloud we are still only displaying 0.0%. It should be good to merge to dev since naresh approved it and it meets the other reqirements, but it is being blocked by SonarCloud.

image

Quinn-Donnelly commented 5 years ago

@VossJacob @Chickwen1 Just validating that these questions have been answered when I cam earlier today.

Chickwen1 commented 5 years ago

Front-end and back-end of add assessment are merged within the dev branches of assessment-service and angular