search

revault / practical-revault

Version 0 specifications for a Revault deployment
Creative Commons Attribution 4.0 International
33 stars 9 forks source link

The acknowledgement to `sig` is overkill #120

Open darosior opened 2 years ago

darosior commented 2 years ago

We don't need to have an explicit acknowledgement here, we can just rely on TCP's ACK.

darosior commented 2 years ago

So the rationale for the WT is that we want it to advertize that it successfully stored the sigs. Say, if we had the TCP ACK but just afterwards the WT gets a database error, we'd consider it stored but it isn't. The same rationale holds for set_spend_tx where, in a deployment with cosigning servers, managers want to be 100% certain the coordinator really could store their Spend tx. The last acknowledgement is the response to sig from the coordinator. It's useless but at this point i don't think it's a good use of our resources to remove it. Marking this issue as low prio.