search

revault / practical-revault

Version 0 specifications for a Revault deployment
Creative Commons Attribution 4.0 International
33 stars 9 forks source link

Increase Cpfp outputs value and revaulting transactions' feerate #60

Closed darosior closed 3 years ago

darosior commented 3 years ago

Also includes a bugfix that slipped in...

darosior commented 3 years ago

Good catch. But now i actually think we shouldn't specify the spend_tx amount ? We don't know how many unvault its batching. -------- Original Message -------- On Dec 12, 2020, 10:46, JSwambo wrote:

@JSwambo commented on this pull request.

In transactions.md:

@@ -101,7 +102,7 @@ path, only spendable after X blocks.

  • value: <unvault_tx outputs[0] value - tx_fee - 330>

Shouldn't we also adjust the output[0] value to: <unvault_tx outputs[0] value - tx_fee - (232 tx_size_vbytes)>

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

darosior commented 3 years ago

Also, it might be cleaner to move the feerate discussions to transactions.md, hmm.

darosior commented 3 years ago

Some small addition after having actually coded this