revault / research

4 stars 1 forks source link

Better refill amount computation #89

Closed darosior closed 3 years ago

darosior commented 3 years ago

Marking as draft since it is currently incorrect but you can have a first look.

darosior commented 3 years ago

So actually i think it's fine. I was biased by testing only with the OTC desk example.

darosior commented 3 years ago

Rationale for this is:

  1. I started cleaning it up
  2. I wanted to comment it by giving a rationale for each part, failed to do so
  3. I had https://github.com/revault/watchtower_paper/issues/76 in mind
  4. I noticed we were too often discarding a new refill, or at least i believe so