search

revault / revault-gui

Revault terminal
https://revault.dev
BSD 3-Clause "New" or "Revised" License
51 stars 8 forks source link

dummy signer #162

Closed edouardparis closed 3 years ago

edouardparis commented 3 years ago

Emulate a hardware wallet

Usage

take xpriv (multiple xpriv ?) as arg Example using the password manager pass:

cargo run -- $(pass my-revault-setup/xpriv)

Communication

Emulator embed a TCP server.

Inspiration

darosior commented 3 years ago

Instead of having to run another binary, do you think it would be doable to have it as a startup option/config? Eg dummy-signer=true.

danielabrozzoni commented 3 years ago

All in the same binary? Do we expect to use that in a real revault setup? If not, I don't think it should be in the binary that we'll give to clients...

darosior commented 3 years ago

Hidden option? They could already shoot them in the foot with, say, bitcoind hidden options.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ Le mardi 27 juillet 2021 à 7:10 PM, Daniela Brozzoni @.***> a écrit :

All in the same binary? Do we expect to use that in a real revault setup? If not, I don't think it should be in the binary that we'll give to clients...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

danielabrozzoni commented 3 years ago

It's not about hidden options or not, it's about not wanting to give them code that for them is useless... If no client will ever see the dummy psbtsigner, should we give that piece of code to them?

What's the pro of having everything in the same binary, anyway?

darosior commented 3 years ago

Not having people running YA thing for trying out.. But yeah i understand your concern. Could even be a build option :p. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ Le mardi 27 juillet 2021 à 7:16 PM, Daniela Brozzoni @.***> a écrit :

It's not about hidden options or not, it's about not wanting to give them code that for them is useless... If no client will ever see the dummy psbtsigner, should we give that piece of code to them?

What's the pro of having everything in the same binary, anyway?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

danielabrozzoni commented 3 years ago

Not having people running YA thing for trying out

Damn, right

edouardparis commented 3 years ago

New update for this issue: we agreed for an other binary because of the iced lack of multiple window support. A emulated HW window will be a good example for HW manufacturers in order for them to understand our view of the sign process for revault revocation txs.