search

revault / revault_tx

Script descriptors and transaction creation routines for Revault
BSD 3-Clause "New" or "Revised" License
15 stars 9 forks source link

Exhaustive parsing checks #68

Open darosior opened 3 years ago

darosior commented 3 years ago

Right now, we only sanity-check the PSBTs in from_psbt_serialized() are sane with regard to our internal assumptions (unwrap()s basically). This may be enough, but we may also want complete parsing checks to be sure that whether a transaction is parsed or created with the constructor it will hold to our requirements (eg, no dust amounts, sane feerate, etc..). This is quite some more hairy code though..

darosior commented 3 years ago

It includes checking the Miniscript s in the PSBT inputs too ...

darosior commented 3 years ago

Part of this was implemented in #70 and #67

darosior commented 3 years ago

This would include checking for duplicated inputs (found by the fuzzer in the Cosigning Server) and all sort of insane transaction in general.

darosior commented 3 years ago

We need to refuse insane amounts as well, working on it.