search

revealapp / Revert

REVEal Rendering Test
revealapp.com
BSD 3-Clause "New" or "Revised" License
364 stars 28 forks source link

Improves tvOS interface #6

Closed brunnoferreira closed 8 years ago

brunnoferreira commented 8 years ago

🚨 Please merge #16 first 🚨

orj commented 8 years ago

:+1:

cuva commented 8 years ago

As a more general comment I reckon the subclasses group is too generic. Try to stick with the current convention - it may be better suited in the Views group.

cuva commented 8 years ago

Looks good @brunnoferreira! Let's discuss the tableView focus / selection when we're both free 👍

Good job.

cuva commented 8 years ago

Also, please install swiftlint and fix all the warnings that are there.

You'll need to add - Revert-tvOS/Sources in the .swiftlint.yml at the root 👍

I won't fix any on my PR because I'm not sure how git will deal with that.. :(

cuva commented 8 years ago

Instead of copying the assets to the tvOS assets (or using an actual shared asset catalog and a specific for each project if there are any target specific assets, I think you've moved the assets). Or git has :P.

On iOS, delorian and xwing are missing.

brunnoferreira commented 8 years ago

I wouldn't blame git fot that, @cuva 😅.

I just re-added the assets to the iOS asset catalog (we shouldn't really share delorian and x-wing between the two targets because they look too small on the TV. They should be replaced as soon as we have new, specific assets).

tonyarnold commented 8 years ago

@cuva that should be addressed by e08034737c0e13724ce6c55dc4f476c2b152c3dc.