Closed DechengMa closed 4 years ago
I can't push my branch to the origin repo: Permission to revealapp/Revert.git denied to DechengMa
, may I get some permissions?
After doing some testing, I found an issue:
Notice that the system colors on the squares and the color RGB value is not automatically inverted when changing between light mode and dark mode.
The system colors and RGB value is only inverted if the cell is reloaded.
Nice one! I think I need to set up a listener for theme changes and then reload the data. BTW should we have a button inside the app for switching between light/dart mode?
After doing some testing, I found an issue: Notice that the system colors on the squares and the color RGB value is not automatically inverted when changing between light mode and dark mode. The system colors and RGB value is only inverted if the cell is reloaded.
Nice one! I think I need to set up a listener for theme changes and then reload the data. BTW should we have a button inside the app for switching between light/dart mode?
Oh yes, having a button in app would be nice. I am thinking if you can have a segment control inside the tableview that switches between:
This PR implemented dynamic colour page, closes #48
Changes
ColourSection
andColourItem
data modelMight need discussion
UIColor.xxx
when input as the data source, instead of.plist
, and decode RGBA from it. For consistency, we might want to use .plist. But use the variable directly can prevent Apple from changing colour value.RevertItem.swift
, we might want to move it to another place.Known issues
Showcase