revealapp / Revert

REVEal Rendering Test
revealapp.com
BSD 3-Clause "New" or "Revised" License
364 stars 28 forks source link

Implement dynamic colour page #60

Closed DechengMa closed 4 years ago

DechengMa commented 4 years ago

This PR implemented dynamic colour page, closes #48

Changes

Might need discussion

Known issues

Showcase

DechengMa commented 4 years ago

I can't push my branch to the origin repo: Permission to revealapp/Revert.git denied to DechengMa, may I get some permissions?

DechengMa commented 4 years ago

After doing some testing, I found an issue:

Notice that the system colors on the squares and the color RGB value is not automatically inverted when changing between light mode and dark mode.

The system colors and RGB value is only inverted if the cell is reloaded.

Aug-20-2020 10-52-34

Nice one! I think I need to set up a listener for theme changes and then reload the data. BTW should we have a button inside the app for switching between light/dart mode?

nabby26 commented 4 years ago

After doing some testing, I found an issue: Notice that the system colors on the squares and the color RGB value is not automatically inverted when changing between light mode and dark mode. The system colors and RGB value is only inverted if the cell is reloaded. Aug-20-2020 10-52-34

Nice one! I think I need to set up a listener for theme changes and then reload the data. BTW should we have a button inside the app for switching between light/dart mode?

Oh yes, having a button in app would be nice. I am thinking if you can have a segment control inside the tableview that switches between: