search

revel / cmd

Command line tools for Revel.
MIT License
62 stars 101 forks source link

Skeleton prod config generates invalid log filenames #125

Closed intel352 closed 6 years ago

intel352 commented 6 years ago

https://github.com/revel/cmd/blob/97ec1422620f1a83cd13738708a109fe092364ca/revel/skeleton/conf/app.conf.template#L200-L202

%(app.name) should be %(app.name)s

Because of the missing s, the resulting log names (when printed from cli):

jlangevin$ ls log/
%(app.name)-critical.json
%(app.name)-error.json
%(app.name)-warn.json
my-app-name-requests.json

Note the requests log is the only one that has the correct format in the generated config.

notzippy commented 6 years ago

Thanks for pointing this out