revel / cmd

Command line tools for Revel.
MIT License
62 stars 101 forks source link

harness: interrupt process on windows as well #200

Closed julidau closed 2 years ago

julidau commented 3 years ago

I tested that this works on windows 10 build 19042.746 with

go version go1.15.6 windows/amd64

Waiting for 60 seconds is unresponsive, and always killing and relaunching the proxy is annoying.

fixes revel/revel#1521

robinodling commented 3 years ago

I'd like this fix..

I'm having issues with the hot-reload on Windows 10, changing a controller doesn't work with hot-reload.

Changed detected, recompiling INFO 21:06:46 app.go:137: Killing revel server pid pid=10532 INFO 21:06:46 app.go:154: Waiting to exit ERROR 21:07:46 app.go:160: Revel app failed to exit in 60 seconds - killing. processid=10532 killerror=nil INFO 21:07:46 app.go:166: Done Waiting to exit

notzippy commented 2 years ago

Thanks !