revelrylabs / bn-mobile-react

BigNeon React Native Repo
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

App becomes unusable while browsing tickets #759

Open Krakaw opened 5 years ago

Krakaw commented 5 years ago

Steps to reproduce

  1. Open the app
  2. Sign in as super user
  3. Go to My Tickets
  4. Choose "Simple Event"
  5. Scroll through about 10 of the tickets, once you hit the 10th odd the app slows to a crawl
bryanjos commented 5 years ago

Can reproduce. I'm sure it has something to do with the image. For this one it's an animated gif which might have made the issue more pronounced. Hopefully we can do some smart caching of the image of something to prevent it

bryanjos commented 5 years ago

@Krakaw so I think the issue here is 2 things

1) There is an animated gif being used as the ticket image. It seems bigger than other images. Are animated gifs going to be allowed? 2) That animated gif is used 16 times in this case. The ticket image and the event information for each ticket stays the same. What if we redesigned the screen to show that information once instead of once per ticket? We could still scroll through the individual ticket stuff that changes such as the QR code, whether it was redeemed, etc

bryanjos commented 5 years ago

I don't know if something changed here, but wondering if this is still an issue? When I tried to reproduce it yesterday, it seemed to be working much better. Any image optimizations happening on the server side now for images?

bryanjos commented 5 years ago

I take back everything I said yesterday, haha

bryanjos commented 5 years ago

I still think #797 is good to look at for fixing/avoiding this kind of bug