revelrylabs / ecto_soft_delete

Soft Deletion for Ecto
MIT License
113 stars 28 forks source link

Chore/dependabot updates 10 3 2023 #154

Closed quinnmccourt closed 5 months ago

quinnmccourt commented 1 year ago

Dependency upgrades: Elixir: 1.9.4 -> 1.13.4 Erlang: 21.1 -> 25.3

ecto_sql: 3.3.3 -> 3.11.2 postgrex: >= 0.0.0 -> 0.17.5 ex_doc: 0.16 -> 0.30.6 credo: 1.2.2 -> 1.7.1 excoveralls: 0.12.2 -> 0.17.1

Test adjustment (https://github.com/elixir-ecto/ecto_sql/blob/master/CHANGELOG.md) due to ecto_sql 3.4 -> 3.5 breaking change

https://github.com/elixir-ecto/ecto_sql/blob/v3.3.3/lib/ecto/migration/runner.ex#L42 -> https://github.com/elixir-ecto/ecto_sql/blob/v3.11.2/lib/ecto/migration/runner.ex#L42

CrystalJewell commented 6 months ago

The warning you're seeing for this about unchanged files with warnings, can be fixed by replacing the use Mix.Config with import Config, IIRC there would be no other changes needed for that.

Screenshot 2024-05-23 at 3 18 51 PM
Samkeer1 commented 6 months ago

@CrystalJewell @grossvogel It seems like all we would need to force here is an ecto_sql bump to >= 3.5.0, and any potential peer dependencies to that.

Samkeer1 commented 5 months ago

@grossvogel I removed the elixir version spec because I thought it might be an unnecessary constraint. I don't think any of the dependencies depend on that version of Elixir but I could be mistaken.

And there's no reason for a >= vs a ~>. I can keep the pattern uniform there.

grossvogel commented 5 months ago

cool... I'd be inclined to keep the elixir version as it was unless we've tested it on versions prior to 1.9, though it's probably not worth the time and effort to do that. Ultimately CI should be running on both the oldest and newest supported language versions, but we can deal with that later