search

revelrylabs / ecto_soft_delete

Soft Deletion for Ecto
MIT License
113 stars 28 forks source link

The deactivated_at clause inclusion check #159

Closed ayan-haider closed 1 year ago

ayan-haider commented 1 year ago

The deleted_at clause here works perfectly fine when we apply each filter in separate where expressions. However, if we do something like this: 

from(c in City, where: c.country == "Sweden" and is_nil(c.deleted_at))

The code does not recognize it and adds another check that is exactly the same.

quinnmccourt commented 1 year ago

Thank you for your contribution! I've given feedback on your PR, but I believe this would be a good addition.