search

revelrylabs / ecto_soft_delete

Soft Deletion for Ecto
MIT License
113 stars 28 forks source link

Relax Elixir version requirement #169

Closed nilsojes closed 4 months ago

nilsojes commented 5 months ago

I think #154 unintentionally locked down the Elixir version to 1.13.

After the latest update we get warning: the dependency :ecto_soft_delete requires Elixir "~> 1.13.4" but you are running on v1.16.2

grossvogel commented 5 months ago

Thanks for the heads-up and the fix @nilsojes !

@Samkeer1 @quinnmccourt do you recall whether we really need anything higher than Elixir 1.9? I know we updated to import Config (added in 1.9), but was there anything else?

nilsojes commented 5 months ago

Thanks for the quick feedback! Just to be clear: there's nothing wrong with the new Elixir version per se. It's just that #154 introduced this change:

-- elixir: "~> 1.9",
++ elixir: "~> 1.13.4",

With that, the Elixir version is "locked" to 1.13.x where it was locked to 1.x before.

grossvogel commented 5 months ago

@nilsojes thanks, I guess my concern is that even "~> 1.13" will cause folks who're on Elixir 1.12 to get a warning similar to yours even though there's really no problem with using this library with that Elixir version. So I'd rather put it back to "~> 1.9" if we still support that version

grossvogel commented 5 months ago

@nilsojes I did some testing and opened https://github.com/revelrylabs/ecto_soft_delete/pull/170 to relax the version requirement a bit further. I turns out we need 1.11 but not quite 1.13 for the supported Ecto version

grossvogel commented 5 months ago

Hey, @nilsojes, v2.0.4 should work for you. Thanks for your contributions!

nilsojes commented 5 months ago

Great! Thank you! 🙂