search

revelrylabs / elixir-nodejs

An Elixir API for calling Node.js functions
MIT License
217 stars 31 forks source link

Fix #14 by adding a `binary` option #16

Closed ccapndave closed 5 years ago

ccapndave commented 5 years ago

Added a binary option to support receiving unicode characters.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 69

Totals Coverage Status
Change from base Build 66: 0.9%
Covered Lines: 40
Relevant Lines: 44
💛 - Coveralls
jwietelmann commented 5 years ago

I'm going to merge this, but should we maybe consider a follow-up to set the option default to true? Any downsides to that?

jwietelmann commented 5 years ago

Coveralls server is acting crazy right now and messing up CI. Will merge when we get CI to run all the way through.

anamba commented 5 years ago

Just ran into this one today and was curious about the status of this PR.

ccapndave commented 5 years ago

Just to let you know I've been using this branch in production for ages now without any problems so it does seem like it works.

oohnoitz commented 5 years ago

I'm just gonna go ahead and merge this in.