search

revelrylabs / elixir-nodejs

An Elixir API for calling Node.js functions
MIT License
214 stars 31 forks source link

implemented importing ESM modules #84

Closed Valian closed 3 months ago

Valian commented 4 months ago

Closes #83.

Changes are purely additive, can be released with a minor release.

Valian commented 4 months ago

Unrelated test is failing, I didn't fix it since there are other PRs doing it

fire commented 4 months ago

Do you know if elixir-nodejs is actively maintained and if this pr will be merged in a regular fashion?

Valian commented 4 months ago

@fire No, I don't know. I believe it's sadly not really maintained :( I'm doing SSR with Vite, and it's impossible to get CJS output right now.

fire commented 4 months ago

If you want to start a organization and fork this // invite me as a contributor I can try helping. Can you list what's on your task list?

Valian commented 4 months ago

I'm considering this, but I'm not sure if I have time...

I'm already working on https://github.com/Valian/live_vue where I needed that functionality, and some other open source libs as well. Not to mention I have a toddler at home 😂

Maybe you could do it?

grossvogel commented 3 months ago

Hey, folks, thanks so much for contributing here and using the library, and apologies for letting it languish!

We'll get back to you very soon with either a fixed-up base branch that we can get this merged into or some info about transferring maintainership.

Valian commented 3 months ago

@grossvogel Hi, maybe I could become a maintainer here? or maybe someone from Reverlylabs could help? Frankly there's not a lot of work needed, mostly fixing main branch using one of the PRs and merging mine 😍

Currently It's blocking my project live_vue from being production-ready https://github.com/Valian/live_vue/issues/2

grossvogel commented 3 months ago

@Valian we just published version 3.0.0 and the tooling on master should be ready to go. If you can merge in / rebase onto the latest upstream we'll get this merged tomorrow. Sorry again for the delay and inattention to the repo, and thanks for your contributions!

Valian commented 3 months ago

@grossvogel Rebased, sorry it took so long! Thanks for taking care of this important project ❤️

grossvogel commented 3 months ago

This change was just published in version 3.1.0

Thanks @Valian!

Valian commented 3 months ago

@grossvogel Thank you! ❤️