search

revelrylabs / elixir-stellar-client

Elixir Client for Stellar
MIT License
20 stars 8 forks source link

[WIP] finishes porting over Stellar XDR types #25

Open sunny-g opened 6 years ago

sunny-g commented 6 years ago

No need to merge yet, only for show :)

grossvogel commented 5 years ago

@sunny-g I noticed this PR uses version 0.2.0 of your XDR package, but I don't see it on hex.pm. Can we expect that to be updated soon?

sunny-g commented 5 years ago

@grossvogel Sorry for that oversight!

0.2.0 currently depends on a fork of ok that's on my github but not on Hex, and as a result, I can't publish it to Hex. What's the recommended process for publishing forks of libraries or libraries with github dependencies?

grossvogel commented 5 years ago

@sunny-g No worries at all, I appreciate your making the XDR package and helping us out with this project!

I agree with your desire not to a package with github dependencies, and it seems like the best option would be to try to get the patch accepted into ok if it's important. If the patch isn't crucial, maybe there's a workaround that would allow you to stick with the official package?