revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

As a user, I want fixes to the modal #119

Open blazebarsamian opened 6 years ago

blazebarsamian commented 6 years ago

There are a few issues with the modal:

IE11 Specific:

aurelieuno commented 6 years ago

Hello, I am looking into the Modal and quick questions: 1) Revelry has a CloseButton, is it the design you would like? (There are different buttons designs available from Revelry, and this is convenient to include it as a props.children to the StatelessModal component to easily modify the close button design) 2) When incorporating the StatelessModal, the isOpen props can be set as true or false (I see from your screenshot this is set to true). I am asking because I could not find a default option set to true, (set to props). 3) The clickToLaunch should be set on which element? (The modal should open when clicking on a specific item right?) I am unsure where to add this (I have it on button in the example below)

Thank you very much! revelry

jwietelmann commented 5 years ago

@blazebarsamian Could you please confirm that the IE11 bug is fixed and close this issue if so?

revelry-stalebot[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.