revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

DatePicker animation needs smoothing #138

Open richardschwalb opened 6 years ago

richardschwalb commented 6 years ago

The DatePicker animation displays 2 issues:

  1. The open/close animation is too fast, should be slowed down by another 250 - 400 ms (500 ms may be too much, but should be considered).
  2. The open/close animation stutters, it needs to be smoothed
prehnRA commented 6 years ago

Thanks for this!

blazebarsamian commented 6 years ago

Update: I slowed down the transition some. Now working on smoothing out the animation so it doesn't stutter

blazebarsamian commented 6 years ago

Heres what I've found regarding the stutter:

I'm going to move this ticket back to icebox for now.

blazebarsamian commented 6 years ago

When you remove most of the elements on the page, the stutter seems to go away and be a lot smoother. So I do think that the stutter is relevant to there being a lot of things on the page and struggling to move the entire page down as the dropdown opens.

achord commented 6 years ago

Animation of an unknown height is tricky. There are several approaches to fixing this design pattern. I lean towards using JS. Here is my quick and dirty codepen, that illustrates one way of doing it.

revelry-stalebot[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.