revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

Accordion & Tab hidden content via CSS #372

Open CheetoMao opened 5 years ago

CheetoMao commented 5 years ago

I'm submitting a ...

What is the current behavior? Accordions and tabs have props now that allow the content to be rendered and hidden using css. (for forms that are used across multiple tabs or accordion panes and/or animating the opening/closing of those elements) https://github.com/revelrylabs/harmonium/issues/121

Currently inline css is added to hide the inactive tabs and accordion panes. We should manage this with a className instead so that styles can be managed better and allow for animation.

The --active modifier className is getting added on all of the elements instead of just the active ones.

The vars and props tables need to be added for both of these components so that users know how to use them.

Also check className and prop name consistency.

What is the expected behavior?

revelry-stalebot[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.