search

revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

Update harmonium.config.js to support a buildPath per plaform #505

Closed bryanjos closed 4 years ago

bryanjos commented 4 years ago

I'm submitting a ...

What is the current behavior?

Currently in harmonium.config.js there is a buildPath property that specifies where build assets will be placed. 

{
  buildPath: './harmonium-settings/',
}

What is the expected behavior?

It would be nice to allow a buildPath per platform

{
  plaforms: {
    scss: {
      buildPath: './harmonium-settings/',
     },
   js: {
      buildPath: './js/',
     }
  }
}
bolivierjr commented 4 years ago

Is it alright if I take a shot at this? Looks like an easy one since you did half the work already! :D

bryanjos commented 4 years ago

Closing, thanks for the PR @bolivierjr!