Closed bryanjos closed 4 years ago
I have the hero stuff pretty close to done but theres some spacing issues caused but row max-widths wrapping the hero and the rev-content padding. I also need to make sure I'm writing any new styles and vars correctly (not sure if theres anything I should be doing differently since adding design-tokens to the proj)
NOTE: the sub-head text should be a larger font-size since its using the Lead classname. From what I understand, Laura has a fix for updating $font-size-medium
so its different (larger) than $font-size-base
in her branch
I pushed up my changes to the branch 514-landing-hero-example
So I've messed with this today but I think this should be fine. Given how docs-site is set up, its wrapping everything on the example pages with rows and the rev-content class which are the causes for the hero not expanding full width. In an actual scenario, the Hero section should be outside of any wrapping rows. The only thing that you would have to deal with is if you had horizontal padding on rev-content - which should be solved on a project basis.
@CheetoMao does that sound okay to you?
@blazebarsamian sorry, didn't see your comment yesterday. That sounds good to me 👍
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
We want to have an example of a landing page made using Harmonium. Below are the affordances i the hero section of a landing page should have.