Closed CheetoMao closed 4 years ago
@bryanjos @blazebarsamian can I get your weigh in on this? Just want to get a 2nd/3rd pair of eyes before I go changing things.
I need to read the document before commenting. Just wanted to post something so you knew I was taking a look at this.
The only question I had at first was if the typography styles just get moved to the base folder, but that seems like what will happen.
I'm good with everything here!
Looks fine to me since the updates you made this morning
updates merged, closing
Our style structure (that ships with Harmonium) could use a few updates so that things are organized a little better. There are a few things that need to be done, but for this ticket, I'm focusing on the top level folders and the main import file. (I will create ticket(s) for organization of files within these folders)
Here's a doc with more detailed comments about the changes: https://docs.google.com/document/d/1BCzfeOlIdRjG17N39N6JBZrnrpqA9Kow6PFP2PR6j3k/edit
Here are the changes I am proposing:
current app.scss @import 'normalizer'; // keep as is @import 'vars/vars'; // change _vars.scss to index.scss @import 'mixins/mixins'; // change _mixins.scss to index.scss @import 'base'; // move to base folder @import 'icons'; // remove @import 'partials/partials'; // change to base, include current base.scss @import 'components/components'; // change _components.scss to index.scss @import 'views/views'; // remove @import 'utilities/utilities'; // change _utilities.scss to index.scss @import 'print/print'; // change _print.scss to index.scss
new app.scss @import 'normalizer'; @import 'vars/'; @import 'mixins/'; @import 'base/'; @import 'components/'; @import 'utilities/'; @import 'print/';