revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

As a user, I want the generation of design tokens to be cleaned up to resolve some issues with lintron. #554

Open blazebarsamian opened 4 years ago

blazebarsamian commented 4 years ago

I'm submitting a ...

What is the current behavior?

What is the expected behavior?

For feature requests: why should the behavior change?

Other information (we love stack traces!)

Here's a pr that you can reference to see what comments its leaving (I already mentioned in the lintron channel about lintron leaving multiples of the same comment on the same line of code so please try to ignore that ☺️ )

blazebarsamian commented 4 years ago

@bryanjos I'm not sure if this is supposed to be a fallback or something? But in harmonium-tokens for react-native (I haven't checked web yet) the first value listed under a transparent color is a hex code and not the rgba value. So when you go to define a transparent color you have to use: export const white80 = harmoniumTokens.color['white-80'].original.value instead of export const white80 = harmoniumTokens.color['white-80'].value

Let me know if this is supposed to just be a fallback so I can let designers know if they ask why it doesn't work the same :)

In this screenshot of my harmonium-tokens file you can see the difference between darker-gray and white-03

Screen Shot 2020-07-09 at 1 03 30 PM