search

revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

As a User I want simple default paragraph styles #578

Closed achord closed 3 years ago

achord commented 3 years ago

I'm submitting a ...

What is the current behavior?

All <p> tags have a default attribute: max-width: 70rem

Screen Shot 2020-09-23 at 10 25 56 AM

A a user this is somewhat baffling. In its current state there needs to be a removal/override on <p> tags. While this is fine for Harmonium documentation, this should not be the default for the framework.

Scenario 1 - as a Harmonium user

For bugs: please provide steps to reproduce and tell us a little about your environment (e.g., what OS and version of the package you're using)

give us enough information to properly diagnose the bug

What is the expected behavior?

tell us what you think should happen instead of what's happening now

For feature requests: why should the behavior change?

explain why your feature request is a good idea

Other information (we love stack traces!)

grossvogel commented 3 years ago

Seems like this was probably put in there based on the idea that long lines are hard to read and making the right thing (readable paragraphs) easier than the wrong thing (full-page paragraphs)?

revelry-stalebot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

achord commented 3 years ago

Seems like this was probably put in there based on the idea that long lines are hard to read and making the right thing (readable paragraphs) easier than the wrong thing (full-page paragraphs)?

IMO. The framework should act an agnostic system and allow a designer/engineer to make decisions about accessibility. Also this is the max-width of the container, which could cause other issues.

blazebarsamian commented 3 years ago

I agree with Steve here. At the very least, maybe we make that max-width a var that can be easily updated?

revelry-stalebot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.