revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

chore: Update_Buttons.scss #585

Closed Ryan-OToole closed 3 years ago

Ryan-OToole commented 3 years ago

Scope: Improved naming conventions scss/components/_Buttons.scss

Changed some discrepancies in terms of the naming convention. &.rev-Button--inverted &.rev-Button--secondary were not following the same pattern established in the rest of the file- they were using color variables for background and vice versa. I added several new variables and utilized them in- &.rev-Button--inverted &.rev-Button--secondary - to solve this problem. Originally was tackling issue #395 but realized it was solved and merged after some time- realized the naming conventions were off in the process and wanted to protect the codebase against unexpected behavior / bugs.

For more details, check out Conventional Commits.

revelry-stalebot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.