Changed some discrepancies in terms of the naming convention. &.rev-Button--inverted &.rev-Button--secondary were not following the same pattern established in the rest of the file- they were using color variables for background and vice versa. I added several new variables and utilized them in- &.rev-Button--inverted &.rev-Button--secondary - to solve this problem. Originally was tackling issue #395 but realized it was solved and merged after some time- realized the naming conventions were off in the process and wanted to protect the codebase against unexpected behavior / bugs.
Please title your PR with:
chore: if your change only impacts developers and doesn't need to make a new package version
fix: if you change is a bug fix which all users should receive
feature: if your change adds new features or new components
BREAKING CHANGE: if you change changing the API or behavior of the library is a way that breaks some projects
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Scope: Improved naming conventions scss/components/_Buttons.scss
Changed some discrepancies in terms of the naming convention. &.rev-Button--inverted &.rev-Button--secondary were not following the same pattern established in the rest of the file- they were using color variables for background and vice versa. I added several new variables and utilized them in- &.rev-Button--inverted &.rev-Button--secondary - to solve this problem. Originally was tackling issue #395 but realized it was solved and merged after some time- realized the naming conventions were off in the process and wanted to protect the codebase against unexpected behavior / bugs.
chore:
if your change only impacts developers and doesn't need to make a new package versionfix:
if you change is a bug fix which all users should receivefeature:
if your change adds new features or new componentsBREAKING CHANGE:
if you change changing the API or behavior of the library is a way that breaks some projectsFor more details, check out Conventional Commits.