search

revelrylabs / harmonium

An opinionated React component framework for teams that move fast.
https://harmonium.revelry.co
MIT License
35 stars 47 forks source link

feature: Added Search Function to Navigation #601

Closed kamrinkennedy closed 3 years ago

kamrinkennedy commented 3 years ago

I added a hot-search bar to the navigation component. It now filters out all categories and components by the search criteria.

When attempting to write tests for this feature, I found that the test infrastructure does not support JSX, and the Navigation component is structured differently than the other testing components. To do so, I would have needed to add additional packages to the repo that may have been unwanted.

revelry-stalebot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

grossvogel commented 3 years ago

sorry @kamrinkennedy, looks like the robot got to this before a human could review... I'm going to open it up again and try to recruit somebody to have a look at this

jpatricknola commented 3 years ago

looks like we got some travis tests failing... or did those always fail?

achord commented 3 years ago

@HauwaAguillard and I plan to pair on this next week.

HauwaAguillard commented 3 years ago

@kamrinkennedy we jammed on this during our internal design meeting today. The search functionality is 💯% a tremendous improvement and works really well. We left a few suggestions and comments on this PR. After you've reviewed the change requests, this should be good to go from a design standpoint. Thank you!

kamrinkennedy commented 3 years ago

Thank you! I’ll review it this evening.

On Wed, Jan 27, 2021 at 4:26 PM HauwaAguillard notifications@github.com wrote:

@kamrinkennedy https://github.com/kamrinkennedy we jammed on this during our internal design meeting today. The search functionality is 💯% a tremendous improvement and works really well. We left a few suggestions and comments on this PR. After you've reviewed the change requests, this should be good to go from a design standpoint. Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/revelrylabs/harmonium/pull/601#issuecomment-768619503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKNPCB4VGX2XP5FS3P4PXDLS4CHIJANCNFSM4USX5PTQ .

revelry-stalebot[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.